Remove gradle.properties #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,7 @@ android { | |||
| minSdkVersion rootProject.ext.minSdkVersion | |||
| targetSdkVersion rootProject.ext.targetSdkVersion | |||
| versionCode 1 | |||
| versionName VERSION_NAME | |||
| versionName version | |||
There was a problem hiding this comment.
does this work or do we need to use project.version?
There was a problem hiding this comment.
It works, but let's use project.version.
wangmengyan95
force-pushed
the
wangmengyan.remove_gradle.properties
branch
from
dc73611 to
bdb3cab
Compare
|
LGTM! |
wangmengyan95
added a commit
that referenced
this pull request
Oct 20, 2015
…properties Remove gradle.properties
|
@wangmengyan95 updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
gradle.propertiesand move version tobuild.gradle.